fix: Replace body so fast-refresh function caching works #628
Conversation
🦋 Changeset detectedLatest commit: d14db48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -669,6 +669,7 @@ describe("React Signals Babel Transform", () => { | |||
| }; | |||
| `); | |||
|
|
|||
| scope.path.scope.crawl(); | |||
There was a problem hiding this comment.
According to babel/babel#8358, the scope bindings are not automatically updated when modifying the ast - this seems to update them
|
Any chance of getting this into a release? |
|
It's been merged for < 24 hours, we'll get to it when we do... I have to first test the signals preact 2.0 release that is attached to this and then publish. I'll try to get this done today but can't make promises |
|
@Artur- nevermind, I forgot I already tested the Preact stuff out but... just forgot.... 😅 the todo-list has been a bit chaotic, it's all released now, thank you again for the contribution! |
|
Thank you very much, remember to calm down and take a break for the holidays :) |
Fixes #626