Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating GMA tested version. #969

Merged
merged 19 commits into from
Apr 25, 2024
Merged

Updating GMA tested version. #969

merged 19 commits into from
Apr 25, 2024

Conversation

jsligh
Copy link
Collaborator

@jsligh jsligh commented Apr 18, 2024

Fixes #968

@jsligh jsligh requested a review from YuriyVelichkoPI April 18, 2024 13:05
@jsligh jsligh self-assigned this Apr 18, 2024
@jsligh jsligh linked an issue Apr 18, 2024 that may be closed by this pull request
Prebid Logs a warning for the GMA Version : 11.2.0 #968
Closed
YuriyVelichkoPI
YuriyVelichkoPI previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsligh
Copy link
Collaborator Author

jsligh commented Apr 18, 2024

A note, the build scripts had to be updated because the newest version of the GMA SDK required an updated version of Cocoapods. It looks like with the --user-install, the newest version of cocoapods was being installed but wasnt being executed because of an incorrect path variable. This all has to do with the fact that MacOS has Ruby v2.7 installed at the root.

@jsligh jsligh requested a review from YuriyVelichkoPI April 23, 2024 13:59
YuriyVelichkoPI
YuriyVelichkoPI approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsligh jsligh merged commit f93d185 into master Apr 25, 2024
4 checks passed
@jsligh jsligh deleted the 968-prebid-logs-a-warning-for-the-gma-version-1120 branch April 25, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriyVelichkoPI YuriyVelichkoPI YuriyVelichkoPI approved these changes

Assignees

@jsligh jsligh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prebid Logs a warning for the GMA Version : 11.2.0
2 participants
@jsligh @YuriyVelichkoPI