New adapter: Port Connatix adapter from PBS-Go #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Feb 25, 2025
| private final String endpointUrl; | ||
| private final JacksonMapper mapper; | ||
|
|
||
| private static final String BIDDER_CURRENCY = "USD"; |
There was a problem hiding this comment.
please do not mix up constants and dependencies, place constants first
| CurrencyConversionService currencyConversionService, | ||
| JacksonMapper mapper) { | ||
| this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); | ||
| this.currencyConversionService = currencyConversionService; |
| @Override | ||
| public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request) { | ||
| // Device IP required - bounce if not available | ||
| if (request.getDevice() == null |
There was a problem hiding this comment.
I'd extract device into a separate variable since it's used later as well
| return headers; | ||
| } | ||
|
|
||
| // check display manager version |
| } | ||
|
|
||
| // check display manager version | ||
| private String buildDisplayManagerVersion(BidRequest request) { |
| .filter(Objects::nonNull) | ||
| .flatMap(Collection::stream) | ||
| .filter(Objects::nonNull) | ||
| .map(bid -> BidderBid.of(bid, getBidType(bid), bidResponse.getCur())) |
There was a problem hiding this comment.
BidderBid.of(bid, getBidType(bid), BID_CURRENCY))
| cookie-family-name: connatix | ||
| iframe: | ||
| url: "https://capi.connatix.com/us/pixel?pId=53&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&callback={{redirect_url}}" | ||
| uid-macro: '$UID' |
| redirect: | ||
| url: "https://capi.connatix.com/us/pixel?pId=52&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&callback={{redirect_url}}" | ||
| uid-macro: '$UID' | ||
| supportCors: false |
Comment on lines
4
to
5
| ortb: | ||
| multiformat-supported: false |
| public class ConnatixTest extends IntegrationTest { | ||
|
|
||
| @Test | ||
| public void openrtb2AuctionShouldRespondWithBannerBidFromConnatix() throws IOException, JSONException { |
There was a problem hiding this comment.
please leave only one test, we test here only the correctness of the configuration
This was
linked to
issues
Feb 25, 2025
Net-burst
changed the title
Net-burst
changed the title
|
updates in response to comments are in progress |
| .orElse(StringUtils.EMPTY); | ||
| } | ||
|
|
||
| private MultiMap resolveHeaders(Device device) { |
| } | ||
|
|
||
| private static String buildDisplayManagerVersion(BidRequest request) { | ||
| final String formatting = "%s-%s"; |
There was a problem hiding this comment.
please extract as a constant
| iframe: | ||
| url: "https://capi.connatix.com/us/pixel?pId=53&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&callback={{redirect_url}}" | ||
| uid-macro: '[UID]' | ||
| supportCors: false |
| final BidRequest bidRequest = givenBidRequest( | ||
| request -> request.device(Device.builder().ip("deviceIp").build()), | ||
| impBuilder -> impBuilder.ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode()))) | ||
| ); |
There was a problem hiding this comment.
according to the code style closing parenthesis should be on the previous line
please double-check everywhere in the PR
AntoxaAntoxic
requested changes
Feb 27, 2025
| iframe: | ||
| url: "https://capi.connatix.com/us/pixel?pId=53&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&callback={{redirect_url}}" | ||
| uid-macro: '[UID]' | ||
| supportCors: false |
AntoxaAntoxic
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
New Connatix Adapter (port from Go)
#3601
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
N/A
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Unit tests with decent coverage
🏎 Quality check