-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping: Update 3rd party dependencies #3786
base: master
Are you sure you want to change the base?
Conversation
Update negative tests for expected number of result messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no Maven conflicts or issues. But could you please also update a functional test: PBS should validate request as alias request and emit proper warnings when validation fails for request
?
The error message changed due to an update in the json-schema-validator dependency to:
and: "Bid response should contain warning"
assert bidResponse.ext?.warnings[PREBID]?.code == [999, 999]
assert bidResponse.ext?.warnings[PREBID]*.message ==
["WARNING: request.imp[0].ext.prebid.bidder.${APPNEXUS.value} was dropped with a reason: request.imp[0].ext.prebid.bidder.${APPNEXUS.value} failed validation.\n" +
"\$: must be valid to one and only one schema, but 0 are valid\n" +
"\$: required property 'placement_id' not found\n" +
"\$: required property 'inv_code' not found\n" +
"\$: required property 'placementId' not found\n" +
"\$: required property 'member' not found\n" +
"\$: required property 'invCode' not found",
"WARNING: request.imp[0].ext must contain at least one valid bidder"]
Hi, updated the PR with the functional test change. Thanks for reviewing. |
🔧 Type of changes
✨ What's the context?
🧠 Rationale behind the change
Update dependencies to improve security posture.
🔎 New Bid Adapter Checklist
🧪 Test plan
mvn clean package
for build and test after each change.🏎 Quality check