Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements.txt to elastic-tube-1d #564

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Sep 1, 2024

Related to #547 and #563.

I have checked that this works on my system. @BenjaminRodenberg please have a consistency check with anything else related you might be working on at the moment.

FYI @NiklasVin

I need this to proceed with precice/precice#2052

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md. -> Not sure if we want to add an entry for every related PR
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my system. I do not have additional requirements for this case at the moment.

@BenjaminRodenberg
Copy link
Member

@MakisH do you want to add a changelog entry? I think it's not really required. We will probably add a single entry for the general change in #563. From my perspective: Ready to merge if you are.

@MakisH MakisH merged commit ff04dc4 into precice:develop Sep 2, 2024
1 check passed
@MakisH MakisH deleted the requirements-elastic-tube-1d branch September 2, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants