Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2: I have a working version with crass, Css parsing imporved #156

Merged
merged 7 commits into from
May 28, 2024
Merged

V2: I have a working version with crass, Css parsing imporved #156

merged 7 commits into from
May 28, 2024

Commits on May 28, 2024

  1. Add Debug gem for easier debuging

    @stoivo
    stoivo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    cb7653b View commit details
    Browse the repository at this point in the history

  2. Move Declarations into separate file

    @stoivo
    stoivo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    3c19c49 View commit details
    Browse the repository at this point in the history

  3. Fix spec to actually test exception message 

    second argument to assert_raises is custom error message
    @stoivo
    stoivo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5690970 View commit details
    Browse the repository at this point in the history

  4. Use custom error instead of ArgumentError 

    Using ArgumentError sounds like a good idea since we received invalid
argument to this method, but this exception is suppose to be when you
pass the wrong number of arguments or missing keywords.
    @stoivo
    stoivo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1c7ee16 View commit details
    Browse the repository at this point in the history

  5. Refactor Declarations#replace_declaration

    @stoivo
    stoivo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b5f8b8d View commit details
    Browse the repository at this point in the history

  6. Replace custom css parser with crass

    @stoivo
    stoivo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    48583cb View commit details
    Browse the repository at this point in the history

  7. Add to x86_64-linux to bundle for CI 

    Error
  Your bundle only supports platforms ["arm64-darwin-22", "java"] but your local
    @stoivo
    stoivo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b22a873 View commit details
    Browse the repository at this point in the history