Improve parse_declarations! performance #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Jul 29, 2024
grosser
reviewed
Jul 29, 2024
leonid-shevtsov
force-pushed
the
improve-parse-declarations-performance
branch
from
230cc70
to
9b3ac77
Compare
|
@grosser I've addressed the comments. As to the splitting by newline - as I recall, I removed it because newlines are not significant in CSS; only semicolons can split declarations. So, they can be handled as any other whitespace (stripped, that is.) I added a test, if you have something else in mind, let's test that as well. |
grosser
reviewed
Aug 16, 2024
grosser
reviewed
Aug 16, 2024
grosser
reviewed
Aug 16, 2024
grosser
reviewed
Aug 16, 2024
leonid-shevtsov
force-pushed
the
improve-parse-declarations-performance
branch
from
9b3ac77
to
b4d986a
Compare
|
Done @grosser. |
|
1.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces regexp-matching code in
parse_declarations!with equivalent substring lookup using.split(&block)and.index.On our benchmarks this shows a 10% improvement in performance measured for overall
add_rule!/add_block!. So, quite a significant one.Pre-Merge Checklist