Add support for if-modified-since header #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. I think this would be good but it looks like we aren't setting the LastModified header when inserting into S3. Does S3 automatically set that or do you have to set that up in the S3 settings for it to do that? Otherwise we should probably set it when storing it in S3. |
|
S3 automatically sets that (like mtime on traditional file systems). |
Nyoroon
force-pushed
the
master
branch
2 times, most recently
from
0d0e72c to
2dc4002
Compare
Nyoroon
force-pushed
the
master
branch
16 times, most recently
from
6b7470a to
667a5fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It maybe little rough, but WDYT?