Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-468 #469

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

issue-468 #469

wants to merge 4 commits into from

Conversation

Shinigami92
Copy link
Member

closes #468

@Shinigami92 Shinigami92 added type: bug Functionality that does not work as intended/expected framework: Svelte Related to the framework Svelte labels Sep 20, 2023
@Shinigami92 Shinigami92 self-assigned this Sep 20, 2023
source: 'unformatted.svelte',
target: 'formatted.svelte',
formatOptions: {
pugFramework: 'svelte',
Copy link
Member Author

@Shinigami92 Shinigami92 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I add parser: 'svelte' here I get an error 🤔
If I leave it, it seems to work

Maybe even it's a compatibility issue with prettier-plugin-svelte

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @rodshtein

Copy link

@rodshtein rodshtein Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, everything worked fine with the previous version of the Svelte plugin prettier-plugin-svelte3.
I need a little time to dig deeper, I'll text you later.

Copy link
Contributor

github-actions bot commented Sep 7, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 94.52% (🎯 90%)
🟰 ±0%
2606 / 2757
🟢 Statements 94.52% (🎯 90%)
🟰 ±0%
2606 / 2757
🟢 Functions 96.29% (🎯 90%)
🟰 ±0%
104 / 108
🟢 Branches 93% (🎯 90%)
⬇️ -0.01%
625 / 672
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Unchanged Files
src/doctype-shortcut-registry.ts 100% 100% 100% 100%
src/index.ts 93.18% 100% 71.42% 93.18% 78-80, 83-85
src/logger.ts 77.46% 90.9% 81.81% 77.46% 37-44, 46, 93-94, 153-157
src/printer.ts 93.93% 94.25% 100% 93.93% 330-331, 364-365, 507-509, 521-530, 535-548, 595-631, 646-647, 682-683, 739-743, 1071-1072, 1164-1165, 1190, 1202-1203, 1440-1441, 1483-1484, 1780-1786, 1824-1829
src/options/common.ts 100% 100% 100% 100%
src/options/constants.ts 100% 100% 100% 100%
src/options/converge.ts 100% 60% 100% 100%
src/options/index.ts 100% 100% 100% 100%
src/options/pug-attribute-separator.ts 90% 75% 100% 90% 51-54
src/options/pug-class-location.ts 100% 100% 100% 100%
src/options/pug-class-notation.ts 100% 100% 100% 100%
src/options/pug-closing-bracket-indent-depth.ts 100% 100% 100% 100%
src/options/pug-comment-preserve-spaces.ts 100% 100% 100% 100%
src/options/pug-explicit-div.ts 100% 100% 100% 100%
src/options/pug-framework.ts 100% 100% 100% 100%
src/options/pug-id-notation.ts 100% 100% 100% 100%
src/options/pug-preserve-attribute-brackets.ts 100% 100% 100% 100%
src/options/pug-single-file-component-indentation.ts 100% 100% 100% 100%
src/options/pug-wrap-attributes.ts 100% 100% 100% 100%
src/options/types.ts 100% 100% 100% 100%
src/options/attribute-sorting/index.ts 100% 100% 100% 100%
src/options/attribute-sorting/utils.ts 95.69% 94.44% 100% 95.69% 78-79, 87-88
src/options/empty-attributes/index.ts 100% 100% 100% 100%
src/options/empty-attributes/types.ts 100% 100% 100% 100%
src/options/empty-attributes/utils.ts 100% 100% 100% 100%
src/utils/angular.ts 100% 100% 100% 100%
src/utils/common.ts 89.67% 86.11% 100% 89.67% 19-20, 25-26, 52-53, 251-252, 254-255, 259-262, 320-321
src/utils/script-mime-types.ts 87.5% 83.33% 100% 87.5% 42-43, 49-50
src/utils/svelte.ts 100% 100% 100% 100%
src/utils/vue.ts 100% 100% 100% 100%
Generated in workflow #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: Svelte Related to the framework Svelte type: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(svelte): the closing </template> tag is moved to the after last word
2 participants