Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] [FE]: J-00FE #57

Merged
merged 2 commits into from
Feb 6, 2025
Merged

[FEAT] [FE]: J-00FE #57

merged 2 commits into from
Feb 6, 2025

Conversation

sungyeong98
Copy link
Collaborator

๐Ÿ“Part

  • BE

  • FE

  • Infra


โœ”๏ธPR Type

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€

  • ๋ฒ„๊ทธ ์ˆ˜์ •

  • ์ฃผ์š” ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์„ฑ๋Šฅ ์ตœ์ ํ™” ๋“ฑ)

  • ๊ฐ„๋‹จ ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์ฃผ์„, ์ฝ”๋“œ ์ปจ๋ฒค์…˜, ์˜คํƒ€ ์ˆ˜์ • ๋“ฑ)

  • ๊ธฐํƒ€ (๊ธฐํƒ€ ์‚ฌํ•ญ ๊ธฐ์ž…)


โœ”๏ธPR Checklist

  • ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€๋ฅผ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž˜ ์ ์šฉ ํ•˜์˜€๋‚˜์š”?

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ / ๋‹จ์œ„ ํ…Œ์ŠคํŠธ or ํ†ตํ•ฉ ํ…Œ์ŠคํŠธ ์ง„ํ–‰ ํ•˜์…จ๋‚˜์š”?


๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • ๋ฉ”์ธ ํŽ˜์ด์ง€ ๋ ˆ์ด์•„์›ƒ ์„ค์ •

    • ๊ฒ€์ƒ‰์ฐฝ ์ƒ์„ฑ(๊ธฐ๋Šฅ์€ ๋ฏธ๊ตฌํ˜„)
    • ๊ณต๊ณ ๊ธ€ ์ถœ๋ ฅ(์„ธ๋ถ€์กฐํšŒ๋Š” ๋ฏธ๊ตฌํ˜„)

๐Ÿ“ˆ์ด๋ฏธ์ง€ ์ฒจ๋ถ€

- ๋ฉ”์ธํ™”๋ฉด์—์„œ ๊ณต๊ณ ๊ธ€ ์ถœ๋ ฅ
- ์„ธ๋ถ€์กฐํšŒ ๊ธฐ๋Šฅ์€ ๋ฏธ๊ตฌํ˜„(๊ตฌํ˜„ ์˜ˆ์ •)
- ๊ฒ€์ƒ‰์ฐฝ ๊ตฌํ˜„(๊ฒ€์ƒ‰ ๊ธฐ๋Šฅ์€ ๋ฏธ๊ตฌํ˜„, ๊ตฌํ˜„ ์˜ˆ์ •)
@sungyeong98 sungyeong98 added frontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—… layout ํ™”๋ฉด ๊ตฌ์„ฑ ๋ฐ ๋ ˆ์ด์•„์›ƒ ์ž‘์—… labels Feb 6, 2025
@sungyeong98 sungyeong98 self-assigned this Feb 6, 2025
@sungyeong98 sungyeong98 linked an issue Feb 6, 2025 that may be closed by this pull request
@sungyeong98 sungyeong98 merged commit 9cd7790 into main Feb 6, 2025
1 check passed
@sungyeong98 sungyeong98 deleted the feature/J-00FE branch February 6, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—… layout ํ™”๋ฉด ๊ตฌ์„ฑ ๋ฐ ๋ ˆ์ด์•„์›ƒ ์ž‘์—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] [FE] J-00FE
1 participant