Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] B-03 #37 #60

Merged
merged 62 commits into from
Feb 6, 2025
Merged

[FEAT] B-03 #37 #60

merged 62 commits into from
Feb 6, 2025

Conversation

zelly-log
Copy link
Collaborator

๐Ÿ“Part

  • BE

  • FE

  • Infra


โœ”๏ธPR Type

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€

  • ๋ฒ„๊ทธ ์ˆ˜์ •

  • ์ฃผ์š” ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์„ฑ๋Šฅ ์ตœ์ ํ™” ๋“ฑ)

  • ๊ฐ„๋‹จ ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์ฃผ์„, ์ฝ”๋“œ ์ปจ๋ฒค์…˜, ์˜คํƒ€ ์ˆ˜์ • ๋“ฑ)

  • ๊ธฐํƒ€ (๊ธฐํƒ€ ์‚ฌํ•ญ ๊ธฐ์ž…)


โœ”๏ธPR Checklist

  • ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€๋ฅผ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž˜ ์ ์šฉ ํ•˜์˜€๋‚˜์š”?

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ / ๋‹จ์œ„ ํ…Œ์ŠคํŠธ or ํ†ตํ•ฉ ํ…Œ์ŠคํŠธ ์ง„ํ–‰ ํ•˜์…จ๋‚˜์š”?


๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • ๊ฒŒ์‹œ๊ธ€ ์ƒ์„ฑ

  • ๋กœ๊ทธ์ธ ํ•œ ์œ ์ €๋งŒ ๊ฒŒ์‹œ๊ธ€ ์ƒ์„ฑ ๊ฐ€๋Šฅ

  • ํ˜„์žฌ ์œ„์น˜ํ•œ ์นดํ…Œ๊ณ ๋ฆฌ์— ๊ธ€ ์ถ”๊ฐ€


๐Ÿ“ˆ์ด๋ฏธ์ง€ ์ฒจ๋ถ€

zelly-log and others added 30 commits February 5, 2025 10:33
- ๋ฉ”์ธ ํ™”๋ฉด
- ๋กœ๊ทธ์ธ ํ™”๋ฉด
- ํ”„๋กœํ•„ ํ™”๋ฉด
@zelly-log zelly-log linked an issue Feb 6, 2025 that may be closed by this pull request
Closed
3 tasks
@zelly-log zelly-log self-assigned this Feb 6, 2025
@zelly-log zelly-log added the enhancement ์‹ ๊ทœ ๊ธฐ๋Šฅ ๊ตฌํ˜„ / ๊ธฐ๋Šฅ ํ–ฅ์ƒ label Feb 6, 2025
Copy link
Collaborator

@kdo1999 kdo1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~

public Long getCategoryId() {
return categoryId;
// DTO -> Entity ๋ณ€ํ™˜
public Post toEntity(Category category, JobPosting jobPosting){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—”ํ‹ฐํ‹ฐ๋กœ ๋ณ€ํ™˜ํ•˜๋Š” ๋กœ์ง์€ ์—”ํ‹ฐํ‹ฐ ๋‚ด๋ถ€์— ์žˆ๋Š”๊ฒŒ ์ข‹์„ ๊ฑฐ ๊ฐ™์•„์š”

@@ -32,7 +33,7 @@ public class Post extends BaseEntity {
// board_id: ๊ฒŒ์‹œ๊ธ€์˜ ๊ณ ์œ  ์‹๋ณ„์ž(PK, Auto Increment)
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
private Long boardId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ…Œ์ด๋ธ” ๋ช…์ด ๋ฐ”๊ผˆ์œผ๋‹ˆ ํ•„๋“œ ๋ช…๋„ postId๊ฐ€ ๋งž์„ ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹น

// ๊ฒŒ์‹œ๊ธ€ ์ƒ์„ฑ
@Transactional
public PostResponseDto createPost(PostCreateRequestDto requestDto, SiteUser user) {
// 1. ๋กœ๊ทธ์ธ ์—ฌ๋ถ€ ํ™•์ธ(๋กœ๊ทธ์ธ ํ•˜์ง€ ์•Š์€ ๊ฒฝ์šฐ์— ๊ธ€ ์ž‘์„ฑ x, ์˜ˆ์™ธ ๋ฐœ์ƒ)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์‹œํ๋ฆฌํ‹ฐ ๋กœ์ง์—์„œ ๋กœ๊ทธ์ธ์ด ์•ˆ๋˜๋ฉด ์•„์˜ˆ ๋„˜์–ด์˜ค์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์— ์ด ๋ถ€๋ถ„์€ ์ œ๊ฑฐํ•ด๋„ ๊ดœ์ฐฎ์„ ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹น

@sungyeong98
Copy link
Collaborator

์ถฉ๋Œ๋งŒ ํ•ด๊ฒฐํ•ด์ฃผ์‹œ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Copy link
Collaborator

@Janghyeonsuk Janghyeonsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค!

@kdo1999 kdo1999 merged commit 1a817e1 into main Feb 6, 2025
1 check failed
@kdo1999 kdo1999 deleted the feature/B-03 branch February 6, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ์‹ ๊ทœ ๊ธฐ๋Šฅ ๊ตฌํ˜„ / ๊ธฐ๋Šฅ ํ–ฅ์ƒ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

B-03
5 participants