Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] R-01 #85

Merged
merged 29 commits into from
Feb 10, 2025
Merged

[FEAT] R-01 #85

merged 29 commits into from
Feb 10, 2025

Conversation

Janghyeonsuk
Copy link
Collaborator

๐Ÿ“Part

  • BE

  • FE

  • Infra


โœ”๏ธPR Type

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€

  • ๋ฒ„๊ทธ ์ˆ˜์ •

  • ์ฃผ์š” ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์„ฑ๋Šฅ ์ตœ์ ํ™” ๋“ฑ)

  • ๊ฐ„๋‹จ ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์ฃผ์„, ์ฝ”๋“œ ์ปจ๋ฒค์…˜, ์˜คํƒ€ ์ˆ˜์ • ๋“ฑ)

  • ๊ธฐํƒ€ (๊ธฐํƒ€ ์‚ฌํ•ญ ๊ธฐ์ž…)


โœ”๏ธPR Checklist

  • ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€๋ฅผ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž˜ ์ ์šฉ ํ•˜์˜€๋‚˜์š”?

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ / ๋‹จ์œ„ ํ…Œ์ŠคํŠธ or ํ†ตํ•ฉ ํ…Œ์ŠคํŠธ ์ง„ํ–‰ ํ•˜์…จ๋‚˜์š”?


๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

resolves #69
close #69

[RecruitmetUser]

  • ๋ชจ์ง‘ ์‹ ์ฒญ (์ค‘๋ณต ๋ฐฉ์ง€, ๋ชจ์ง‘ ์ข…๋ฃŒ๋œ ๊ฒŒ์‹œ๊ธ€ ์‹ ์ฒญ ๋ถˆ๊ฐ€)
  • ๋ชจ์ง‘ ์ทจ์†Œ (์ด๋ฏธ ๋ชจ์ง‘์ด ์ข…๋ฃŒ๋œ ๊ฒŒ์‹œ๊ธ€ ๋ชจ์ง‘ ์ทจ์†Œ ๋ถˆ๊ฐ€๋Šฅ)
  • ๋ชจ์ง‘ ์™„๋ฃŒ๋œ ๊ฒŒ์‹œ๊ธ€ ๋ชฉ๋ก ํŽ˜์ด์ง•(๋กœ๊ทธ์ธํ•œ ์œ ์ €)

[RecruitmentAuthor]

  • ๋ชจ์ง‘ ์Šน์ธ (๊ฒŒ์‹œ๊ธ€ ์ž‘์„ฑ์ž๋งŒ ๊ฐ€๋Šฅ, Closed ์ƒํƒœ๊ฐ€ ์•„๋‹Œ ๊ฒŒ์‹œ๊ธ€๋งŒ ๊ฐ€๋Šฅ, ๋ชจ์ง‘ ์‹ ์ฒญ(Applied)์ƒํƒœ์ผ๋•Œ๋งŒ ๊ฐ€๋Šฅ)

  • ๋ชจ์ง‘ ์Šน์ธ์‹œ ๋ชจ์ง‘ ์ธ์›์ด ๋ชจ๋‘ ์ฐผ์„ ๊ฒฝ์šฐ ๋ชจ์ง‘ ๊ฒŒ์‹œ๊ธ€ ์ƒํƒœ Closed๋กœ ๋ฐ›๋Š” ๋กœ์ง ๊ตฌํ˜„ ํ•„์š”

  • ๋ชจ์ง‘ ๊ฑฐ์ ˆ (๊ฒŒ์‹œ๊ธ€ ์ž‘์„ฑ์ž๋งŒ ๊ฐ€๋Šฅ, Closed ์ƒํƒœ๊ฐ€ ์•„๋‹Œ ๊ฒŒ์‹œ๊ธ€๋งŒ ๊ฐ€๋Šฅ, ๋ชจ์ง‘ ์‹ ์ฒญ(Applied)์ƒํƒœ์ผ๋•Œ๋งŒ ๊ฐ€๋Šฅ)

  • ๋ชจ์ง‘ ์ง€์›์ž ๋ชฉ๋ก ์กฐํšŒ(๊ฒŒ์‹œ๊ธ€ ์ž‘์„ฑ์ž๊ฐ€ ์ˆ˜๋ฝ, ๊ฑฐ์ ˆ ํ•˜๊ธฐ ์œ„ํ•ด์„œ)

  • ๋ชจ์ง‘ ์™„๋ฃŒํ›„ ์Šน์ธ๋œ ์ง€์›์ž ๋ชฉ๋ก ์กฐํšŒ


๐Ÿ“ˆ์ด๋ฏธ์ง€ ์ฒจ๋ถ€

@Janghyeonsuk Janghyeonsuk added the enhancement ์‹ ๊ทœ ๊ธฐ๋Šฅ ๊ตฌํ˜„ / ๊ธฐ๋Šฅ ํ–ฅ์ƒ label Feb 9, 2025
@Janghyeonsuk Janghyeonsuk linked an issue Feb 9, 2025 that may be closed by this pull request
Closed
3 tasks
Copy link
Collaborator

@kdo1999 kdo1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RecruitmetUser, RecruitmentAuthor๋ฅผ ๋ถ„๋ฆฌํ•˜์…จ๋˜๋ฐ RestAPI๊ฐ€ ์ž์›์„ ๊ธฐ์ค€์œผ๋กœ URI๋ฅผ ๋‚˜๋ˆ„๋Š”๋ฐ
์ œ ์ƒ๊ฐ์€ ๋‘๊ฐœ๋ฅผ ๋ถ„๋ฆฌ ์‹œํ‚ฌ ํ•„์š”์„ฑ์ด ๋Š๊ปด์ง€์ง€๋Š” ์•Š์•˜๋˜ ๊ฑฐ ๊ฐ™์•„์„œ ์„ค๊ณ„ํ•˜์‹ค ๋•Œ ์–ด๋–ค ์ด์œ ์—์„œ ๋ถ„๋ฆฌํ•˜์…จ๋Š”์ง€๋„ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค!

์ข€ ๋Šฆ๊ฒŒ ํ™•์ธ์„ํ•ด์„œ ์ผ๋‹จ ๋ˆˆ์— ๋ณด์ด๋Š” ๋ถ€๋ถ„๋“ค๋งŒ ์ฝ”๋ฉ˜ํŠธ ์ž‘์„ฑ ํ•ด๋’€๊ณ  ์˜ค๋Š˜ ์˜ค์ „์— ๋‹ค์‹œ ํ•œ ๋ฒˆ ํ™•์ธํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค!

์ˆ˜๊ณ  ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค~

Copy link
Collaborator

@kdo1999 kdo1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Join์„ ์‚ฌ์šฉํ•˜๋ฉด ์ง€์—ฐ ๋กœ๋”ฉ์ด ์ ์šฉ๋˜์–ด N+1 ๋ฌธ์ œ ํ•ด๊ฒฐ์„ ์œ„ํ•ด fetch join์„ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ์ง€๋งŒ fetch join์‹œ์—๋Š” ํ•„์š”๋กœ ํ•˜์ง€ ์•Š๋Š” ์ปฌ๋Ÿผ์˜ ๋ฐ์ดํ„ฐ๋„ ๋‹ค ๋ถˆ๋Ÿฌ์™€์ง€๋Š” ๋‹จ์ ์ด ์žˆ์Šต๋‹ˆ๋‹ค.

JobSkill์ด๋ž‘ SiteUser์˜ ์ปฌ๋Ÿผ์ด ๊ทธ๋ ‡๊ฒŒ ๋งŽ์ง€ ์•Š์•„์„œ ํฌ๊ฒŒ ์ค‘์š”ํ•˜์ง„ ์•Š์ง€๋งŒ
๋งŒ์•ฝ ์ปฌ๋Ÿผ์˜ ๊ฐœ์ˆ˜๋ž‘ ์กฐํšŒํ•ด์•ผ๋˜๋Š” ๋ฐ์ดํ„ฐ ๊ฐœ์ˆ˜๊ฐ€ ๋งŽ์•„์งˆ ๊ฒฝ์šฐ์—๋Š”
์—”ํ‹ฐํ‹ฐ ์กฐํšŒ๊ฐ€ ์•„๋‹Œ Dto ์กฐํšŒ๋กœ ํ•„์š”ํ•œ ์ปฌ๋Ÿผ๋งŒ ๊ฐ€์ ธ์™€์„œ ์ฑ„์šฐ๋Š” ๋ฐฉ๋ฒ•๋„ ์žˆ์Šต๋‹ˆ๋‹ค.

์ฐธ๊ณ ํ•ด๋ณด๋ฉด ์ข‹์„ ๊ฑฐ ๊ฐ™์•„ ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊น๋‹ˆ๋‹ค!

@Janghyeonsuk Janghyeonsuk merged commit 337af43 into main Feb 10, 2025
1 check passed
@Janghyeonsuk Janghyeonsuk deleted the feature/R-01 branch February 10, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ์‹ ๊ทœ ๊ธฐ๋Šฅ ๊ตฌํ˜„ / ๊ธฐ๋Šฅ ํ–ฅ์ƒ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R-01
4 participants