-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] R-01 #85
[FEAT] R-01 #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RecruitmetUser, RecruitmentAuthor๋ฅผ ๋ถ๋ฆฌํ์
จ๋๋ฐ RestAPI๊ฐ ์์์ ๊ธฐ์ค์ผ๋ก URI๋ฅผ ๋๋๋๋ฐ
์ ์๊ฐ์ ๋๊ฐ๋ฅผ ๋ถ๋ฆฌ ์ํฌ ํ์์ฑ์ด ๋๊ปด์ง์ง๋ ์์๋ ๊ฑฐ ๊ฐ์์ ์ค๊ณํ์ค ๋ ์ด๋ค ์ด์ ์์ ๋ถ๋ฆฌํ์
จ๋์ง๋ ๊ถ๊ธํฉ๋๋ค!
์ข ๋ฆ๊ฒ ํ์ธ์ํด์ ์ผ๋จ ๋์ ๋ณด์ด๋ ๋ถ๋ถ๋ค๋ง ์ฝ๋ฉํธ ์์ฑ ํด๋๊ณ ์ค๋ ์ค์ ์ ๋ค์ ํ ๋ฒ ํ์ธํด๋ณด๊ฒ ์ต๋๋ค!
์๊ณ ๋ง์ผ์ จ์ต๋๋ค~
backend/src/main/java/com/backend/domain/post/service/PostService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/backend/domain/post/service/PostService.java
Outdated
Show resolved
Hide resolved
...ain/java/com/backend/domain/recruitmentUser/controller/ApiV1RecruitmentAuthorController.java
Show resolved
Hide resolved
backend/src/main/java/com/backend/domain/recruitmentUser/service/RecruitmentUserService.java
Outdated
Show resolved
Hide resolved
...d/src/main/java/com/backend/domain/recruitmentUser/repository/RecruitmentUserRepository.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๊ณ ํ์ จ์ต๋๋ค~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Join์ ์ฌ์ฉํ๋ฉด ์ง์ฐ ๋ก๋ฉ์ด ์ ์ฉ๋์ด N+1 ๋ฌธ์ ํด๊ฒฐ์ ์ํด fetch join์ ์ฌ์ฉํ ์ ์์ง๋ง fetch join์์๋ ํ์๋ก ํ์ง ์๋ ์ปฌ๋ผ์ ๋ฐ์ดํฐ๋ ๋ค ๋ถ๋ฌ์์ง๋ ๋จ์ ์ด ์์ต๋๋ค.
JobSkill์ด๋ SiteUser์ ์ปฌ๋ผ์ด ๊ทธ๋ ๊ฒ ๋ง์ง ์์์ ํฌ๊ฒ ์ค์ํ์ง ์์ง๋ง
๋ง์ฝ ์ปฌ๋ผ์ ๊ฐ์๋ ์กฐํํด์ผ๋๋ ๋ฐ์ดํฐ ๊ฐ์๊ฐ ๋ง์์ง ๊ฒฝ์ฐ์๋
์ํฐํฐ ์กฐํ๊ฐ ์๋ Dto ์กฐํ๋ก ํ์ํ ์ปฌ๋ผ๋ง ๊ฐ์ ธ์์ ์ฑ์ฐ๋ ๋ฐฉ๋ฒ๋ ์์ต๋๋ค.
์ฐธ๊ณ ํด๋ณด๋ฉด ์ข์ ๊ฑฐ ๊ฐ์ ์ฝ๋ฉํธ ๋จ๊น๋๋ค!
๐Part
BE
FE
Infra
โ๏ธPR Type
์๋ก์ด ๊ธฐ๋ฅ ์ถ๊ฐ
๋ฒ๊ทธ ์์
์ฃผ์ ์ฝ๋ ๋ฆฌํํ ๋ง (์ฑ๋ฅ ์ต์ ํ ๋ฑ)
๊ฐ๋จ ์ฝ๋ ๋ฆฌํํ ๋ง (์ฃผ์, ์ฝ๋ ์ปจ๋ฒค์ , ์คํ ์์ ๋ฑ)
๊ธฐํ (๊ธฐํ ์ฌํญ ๊ธฐ์ )
โ๏ธPR Checklist
์ปค๋ฐ ๋ฉ์ธ์ง๋ฅผ ์ปจ๋ฒค์ ์ ๋ง๊ฒ ์ ์ ์ฉ ํ์๋์?
ํ ์คํธ ์ฝ๋ ์์ฑ / ๋จ์ ํ ์คํธ or ํตํฉ ํ ์คํธ ์งํ ํ์ จ๋์?
๐ ์์ ๋ด์ฉ
resolves #69
close #69
[RecruitmetUser]
[RecruitmentAuthor]
๋ชจ์ง ์น์ธ (๊ฒ์๊ธ ์์ฑ์๋ง ๊ฐ๋ฅ, Closed ์ํ๊ฐ ์๋ ๊ฒ์๊ธ๋ง ๊ฐ๋ฅ, ๋ชจ์ง ์ ์ฒญ(Applied)์ํ์ผ๋๋ง ๊ฐ๋ฅ)
๋ชจ์ง ์น์ธ์ ๋ชจ์ง ์ธ์์ด ๋ชจ๋ ์ฐผ์ ๊ฒฝ์ฐ ๋ชจ์ง ๊ฒ์๊ธ ์ํ Closed๋ก ๋ฐ๋ ๋ก์ง ๊ตฌํ ํ์
๋ชจ์ง ๊ฑฐ์ (๊ฒ์๊ธ ์์ฑ์๋ง ๊ฐ๋ฅ, Closed ์ํ๊ฐ ์๋ ๊ฒ์๊ธ๋ง ๊ฐ๋ฅ, ๋ชจ์ง ์ ์ฒญ(Applied)์ํ์ผ๋๋ง ๊ฐ๋ฅ)
๋ชจ์ง ์ง์์ ๋ชฉ๋ก ์กฐํ(๊ฒ์๊ธ ์์ฑ์๊ฐ ์๋ฝ, ๊ฑฐ์ ํ๊ธฐ ์ํด์)
๋ชจ์ง ์๋ฃํ ์น์ธ๋ ์ง์์ ๋ชฉ๋ก ์กฐํ
๐์ด๋ฏธ์ง ์ฒจ๋ถ