Improve JSDocs and refactor notifier #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlipWarthog
reviewed
Aug 16, 2024
src/extension.ts
Outdated
| * @param {TextDocument} document - The document in which the hover was invoked. | ||
| * @param {Position} position - The position at which the hover was invoked. | ||
| * @returns {Hover | null} A Hover object containing the hover information, or null if no information is available. | ||
| */ | ||
| provideHover(document: TextDocument, position: Position): Hover | null { | ||
| _output.appendLine(`In hover, position is ${position.line}:${position.character}`); |
There was a problem hiding this comment.
Do you wanna clean up some of these outputs I added for debugging hover? I don't think we need it outputting all this anymore now that it works.
FlipWarthog
approved these changes
Aug 16, 2024
|
Good point I just commented them out instead of deleting them entirely. |
Works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26