fix(picklist): emit events for mouse and keyboard selection #17638
+109
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and focus related code from PickList; emit events when selection is changed
|
@infe42 is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
infe42
changed the title
infe42
changed the title
mertsincan
added
the
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17323
This PR removes a lot of code from the PickList component that tries to deal with selection and focus - which is already done by the ListBox component itself. Also, some of this code was actually never used (like
onItemClick).After this PR the PickList component also emits events for selection changes again, which fixes the bug mentioned above.