fix: CSS insertion when using ShadowDom #16567 #17646
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ShadowDOM mode an application using primeng 18+ styles are not applied. It looks like insertion rules should be: * variables can be inserted in `document` * component styles must be inserted in * child shadowRoot (if the component use `ViewEncapsulation.ShadowDom`) * getRootNode (if a component is a child of shadowRoot) Remaining issues: * it looks like a component does not insert styles if already present in the page (issue is that one can be in shadowRoot and the other the higher level) * common styles are not available in shadowRoot Related to primefaces#16567
|
Deployment failed with the following error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ShadowDOM mode an application using primeng 18+ styles are not applied because inserted in
document.head. Those styles are not available in shadowRoot.Changes
It looks like insertion rules should be:
documentViewEncapsulation.ShadowDom)Remaining issues:
Example on the carousel component
ViewEncapsulation.NoneViewEncapsulation.ShadowDom- no styleExample of a simple application using the primeng table
When using
encapsulation: ViewEncapsulation.ShadowDominstead of
Any help from a more experimented user on the theming system would be appreciated!
Related to #16567