cleanup: remove deprecated underline attribute

[khiga8]

Small change to clean up deprecated underline attributes!

I was getting bothered in storybook files that this underline attribute is deprecated, but it's used in many examples.

Let's clean this up so developers don't add undesirable usage in their code when copying examples from Primer's storybook.

Changelog

New

Changed

Removed

• Removed undesirable underline attribute usage in stories.

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

⚠️ No Changeset found

Latest commit: cb06c3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	104.39 KB (0%)
packages/react/dist/browser.umd.js	104.91 KB (0%)

[TylerJDev]

Since we're using inline, do we need to add data-a11y-link-underlines="true" to the containers of the links so that the underlines will show? I did something similar in another PR, but now I'm wondering if there's some sort of base Storybook component we could add this to 🤔

Edit: We might be able to add the data-* attribute to the <div> in preview.jsx, if we did go that route!

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[khiga8]

Edit: We might be able to add the data-* attribute to the

in preview.jsx, if we did go that route!

@TylerJDev I think this route makes sense! We have something similar in dotcom!

[khiga8]

The Link Devonly inline story has examples to show what impact this underline data attribute has.

Adding this conditional to avoid ending up with this markup on that particular story, because it results in all links being underlined.=:

<div data-a11y-link-underlines="true">
  ... 
  ...
  <div data-a11y-link-underlines="false">
     Learn more <Link href="#">about GitHub</Link>
  </div>

[TylerJDev]

Looks great! Thank you for all the work on this ✨