RelativeTime: Remove title from Storybook stories

[TylerJDev]

Context https://github.com/github/accessibility-audits/issues/10169

Adds new stories:

• Dynamic Relative Time
• Long Date

Question for reviewers: Should we add any other stories to showcase usage of RelativeTime without title?

Changelog

New

• Adds story to show off RelativeTime without title

Changed

• Add noTitle to RelativeTime stories

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

⚠️ No Changeset found

Latest commit: f8b6bc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	105.53 KB (0%)
packages/react/dist/browser.umd.js	105.9 KB (0%)

[khiga8]

Looks good to me! It's cool that the relative-time already had the noTitle prop!

I think it's worth documenting the existence of the noTitle prop somewhere (whether the story or the docs).

[kendallgassner]

Is there ever a time we would want a title? Why don't we hard code no-title=true in the component?

[TylerJDev]

Thank you @khiga8!

I think it's worth documenting the existence of the noTitle prop somewhere (whether the story or the docs).

I see we have noTitle in our props table, should we add it elsewhere? 🤔

[TylerJDev]

Is there ever a time we would want a title? Why don't we hard code no-title=true in the component?

To be honest, not really. The goal is to eventually deprecate the prop and make not having a title the default, regardless of the prop. The only reason why I'm not doing this just yet is because I'm not entirely sure how often it's being used by users today. I'm hoping that by adding a lint rule, we can steer teams to more accessible patterns before removing it completely.

[kendallgassner]

The only reason why I'm not doing this just yet is because I'm not entirely sure how often it's being used by users today. I'm hoping that by adding a lint rule, we can steer teams to more accessible patterns before removing it completely.

Can Primer Query only query github repos? Or can we use it to query for this across GitHub

[TylerJDev]

Can Primer Query only query github repos? Or can we use it to query for this across GitHub

Yeah! It seems like we use the title on all instances that exist in Dotcom 😭

[kendallgassner]

Seems like a quick win could be adding noTitle to all use cases though!

[TylerJDev]

Seems like a quick win could be adding noTitle to all use cases though!

I agree! Will have a follow-up PR that will add noTitle={true} to the component by default.