refactor Dialog to use <dialog> internally #4570
Annotations
11 errors and 2 warnings
|
app/components/primer/dialog_helpers.ts#L46
Parameter 'event' implicitly has an 'any' type.
|
app/components/primer/dialog_helpers.ts#L49
'dialog' is possibly 'null'.
|
app/components/primer/dialog_helpers.ts#L52
'dialog' is possibly 'null'.
|
app/components/primer/dialog_helpers.ts#L60
'dialog' is possibly 'null'.
|
app/components/primer/dialog_helpers.ts#L75
Property 'ModalDialogElement' does not exist on type 'Window & typeof globalThis'. Did you mean 'HTMLDialogElement'?
|
node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L7
All declarations of 'oldState' must have identical modifiers.
|
node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L8
All declarations of 'newState' must have identical modifiers.
|
node_modules/@oddbird/popover-polyfill/dist/index.d.ts#L11
Subsequent property declarations must have the same type. Property 'popover' must be of type 'string | null', but here has type '"auto" | "manual" | null'.
|
node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
|
node_modules/typescript/lib/lib.dom.d.ts#L9683
Interface 'HTMLButtonElement' cannot simultaneously extend types 'PopoverInvokerElement' and 'PopoverToggleTargetElementInvoker'.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: phulsechinmay/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
The logs for this run have expired and are no longer available.
Loading