Merge branch 'main' into fix-tooltips-opening-when-focus-is-removed-w…

…hile-displaying

.changeset/mean-bottles-unite.md

@@ -0,0 +1,7 @@
+---
+"@primer/view-components": minor
+---
+
+Adds an 'inactive' state to buttons. An inactive button looks disabled and has aria-disabled, but it can still be clicked and focused. This was added to support buttons that are broken due to availability issues, but can't be removed from the page.
+
+<!-- Changed components: Primer::Beta::Button, Primer::Beta::BaseButton, Primer::Beta::IconButton -->

.github/workflows/release.yml

@@ -33,10 +33,6 @@ jobs:
           npm ci
           bundle install
 
-      # `changesets/action` depends on @changesets/cli being installed
-      # and we cannot add it as dependency because it conflicts with `primer-changesets-cli`
-      - run: npm install @changesets/[email protected]
-
       # Use the primer GitHub App for authentication.
       # See: https://github.com/organizations/primer/settings/apps/primer
       - id: get-access-token

app/components/primer/beta/base_button.rb

@@ -19,12 +19,14 @@ class BaseButton < Primer::Component
       # @param type [Symbol] <%= one_of(Primer::Beta::BaseButton::TYPE_OPTIONS) %>
       # @param block [Boolean] Whether button is full-width with `display: block`.
       # @param disabled [Boolean] Whether or not the button is disabled. If true, this option forces `tag:` to `:button`.
+      # @param inactive [Boolean] Whether the button looks visually disabled, but can still accept all the same interactions as an enabled button.
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       def initialize(
         tag: DEFAULT_TAG,
         type: DEFAULT_TYPE,
         block: false,
         disabled: false,
+        inactive: false,
         **system_arguments
       )
         @system_arguments = system_arguments
@@ -37,6 +39,8 @@ def initialize(
           "btn-block" => block
         )
 
+        @system_arguments[:"aria-disabled"] = true if inactive
+
         @disabled = disabled
         return unless @disabled
 

app/components/primer/beta/button.pcss

@@ -47,11 +47,15 @@
     transition: none;
   }
 
-  &:disabled,
-  &[aria-disabled='true'] {
+  &:disabled {
     cursor: not-allowed;
     box-shadow: none;
   }
+
+  &[aria-disabled='true'] {
+    cursor: default;
+    box-shadow: none;
+  }
 }
 
 .Button-withTooltip {