Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegmentedControl alignment fixes #2286

Merged
merged 12 commits into from
Oct 18, 2023
Merged

SegmentedControl alignment fixes #2286

merged 12 commits into from
Oct 18, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Oct 16, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

I noticed some buggy alignment while working on the Tooltip, so just cleaning it up a little.

  • Adjusted the nested border-radius to respect the parent button border-radius
  • Added size classes at the top level to better adjust individual item sizing

Screenshots

Before:
SegmentedControl alignment issues before

After:
SegmentedControl alignment issues after

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@langermank langermank requested a review from a team as a code owner October 16, 2023 18:33
@langermank langermank requested review from a team, simurai and keithamus October 16, 2023 18:33
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

🦋 Changeset detected

Latest commit: f1cbdea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added ruby Pull requests that update Ruby code css Pull requests that update CSS code labels Oct 16, 2023
@langermank langermank temporarily deployed to preview October 16, 2023 18:36 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank temporarily deployed to preview October 16, 2023 19:13 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to preview October 16, 2023 19:40 — with GitHub Actions Inactive
@langermank langermank marked this pull request as draft October 16, 2023 21:56
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates 👍🏻

@jonrohan jonrohan merged commit 02e7f78 into main Oct 18, 2023
@jonrohan jonrohan deleted the segmented-control-bug-fixes branch October 18, 2023 19:52
@jonrohan jonrohan temporarily deployed to preview October 18, 2023 19:52 — with GitHub Actions Inactive
@primer primer bot mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code patch release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants