Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure dialog is position: fixed #2533

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

keithamus
Copy link
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Another regression from #2496 - position: static was set but this causes dialogs-within-dialogs to be rendered inside eachother, rather than on top of eachother.

We can use position: fixed instead. The old dialog would be nested inside a Overlay-backdrop element which was position: fixed, but now the backdrop is a pseudo element that rule no longer applies.

Screenshots

a screenshot of the GitHub user status dialog rendering awkwardly inside the user menu

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Made it position: fixed.

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@keithamus keithamus requested a review from a team as a code owner January 24, 2024 12:24
@keithamus keithamus requested a review from langermank January 24, 2024 12:24

This comment was marked as outdated.

This comment was marked as outdated.

@keithamus keithamus requested review from a team and jonrohan January 24, 2024 12:28
@keithamus keithamus force-pushed the ensure-dialog-is-position-fixed branch from 709e807 to 9945234 Compare January 24, 2024 12:44
@keithamus keithamus added the skip changeset Pull requests that don't change the library output label Jan 24, 2024
@keithamus keithamus enabled auto-merge (squash) January 24, 2024 14:27
@keithamus keithamus merged commit 09fae5f into main Jan 24, 2024
30 checks passed
@keithamus keithamus deleted the ensure-dialog-is-position-fixed branch January 24, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants