Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.5.0-beta release #451

Merged
merged 6 commits into from
Oct 25, 2023
Merged

v1.5.0-beta release #451

merged 6 commits into from
Oct 25, 2023

Conversation

Alexangelj
Copy link
Contributor

@Alexangelj Alexangelj commented Oct 23, 2023 •
edited
Loading

Changelog

  • Removes the DEFAULT_STRATEGY state variable.
  • Removes the NormalStrategy.sol dependency from Portfolio, so Portfolio is strategy agnostic.
  • Removes the magic zero address variable to utilize the default strategy in Portfolio.createPool

Notes

  • Create pool must have a strategy passed to create pool. The call will fail if the call to the strategy contract's afterCreate hook fails.
  • The setup & test suite makes use of the normal strategy, which might be removed from the codebase. The tests should make use of a test strategy.
  • The poolId's altered information (the first 4 bits in the poolId) is hardcoded to 0x0, since it's set to false in createPool. This should be utilized or removed altogether

Requirements

  • Deployment addresses for v1.5.0-beta

@Alexangelj Alexangelj marked this pull request as ready for review October 25, 2023 18:03
@0xJepsen 0xJepsen self-requested a review October 25, 2023 18:44
0xJepsen
0xJepsen approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean. Glad we shipped this

@Alexangelj Alexangelj merged commit afc317e into main Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexangelj @0xJepsen