Update dependencies and upgrade to Flutter 3.14 #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to test it on monday. Please also update the github workflow files. |
|
@adeveloper-wq tested mapbox 0.4.4 with the flutter profiler for the android version. Looks good to me. No memory leak found. |
|
TODOs (don't know yet if iOS only or also Android):
|
pubspec.yaml
Outdated
| url: https://github.com/mapbox/mapbox-maps-flutter | ||
| ref: yds-fix-memory-leaks | ||
| intl: ^0.18.1 # Used for date formats | ||
| mapbox_maps_flutter: ^0.4.4 # Used to dislpay map |
PhilippMatthes
changed the title
PhilippMatthes
changed the title
|
Note: we should wait for Flutter 3.14 as it fixes a bug when testing on iOS 17 devices |
PaulPickhardt
force-pushed
the
dependency-update
branch
from
0ed490a to
2c68d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Flutter to 3.13.0
flutter format .was removed in 3.10. We need to usedart format .instead. We might need to update this in the github actions as well.Upgrade resolvable dependencies.
Upgrade Mapbox to 0.4.4.
No obvious errors or bugs found. Layers and Datapoints can be watched and switched without crashes. Still need to check the profiler (Check memory leak).
@adeveloper-wq please check if it also works on IOS.