Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flutter to 3.19.6 and package upgrades (especially Mapbox 2.0.0) #582

Merged
merged 11 commits into from
Jun 12, 2024

Conversation

PaulPickhardt
Copy link
Member

@PaulPickhardt PaulPickhardt commented Jun 4, 2024

If available, link to the ticket

Closes: #542

I could only upgrade to Flutter 3.19.6 due to a bug regarding UniqueKey. The toString() method behaves differently in release mode. We habe to wait for the hotfix.

With Flutter 3.22.0 the colorScheme attributes background, onBackground and surfaceVariantget deprecated. I already refactored this when testing the 3.22.1 version. I think we should apply this change already.

Our color mapping was not consistent anyway. Primary and surface were the same. The migration for background suggests moving it to surface.

That is the color mapping I applied:
surface = value of background
onSurface = value of onBackground

The use in the code needed to change:
surface => primary
onSurface => onPrimary
background => surface
onBackground => onSurface

When we upgrade to flutter 3.22.x, the only thing we need to change is: renaming surfaceVariant tosurfaceContainer.

QA Checklist

Author

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Reviewer

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

@PaulPickhardt PaulPickhardt changed the title Package update Upgrade Flutter to 3.19.6 Jun 4, 2024
@PaulPickhardt PaulPickhardt changed the title Upgrade Flutter to 3.19.6 Upgrade Flutter to 3.19.6 and package upgrades (especially Mapbox 2.0.0) Jun 4, 2024
@adeveloper-wq
Copy link
Member

There is now a white bar at the bottom of the display. This shouldn't be there.

Bildschirmfoto 2024-06-11 um 10 54 50 2

README.md Outdated Show resolved Hide resolved
Copy link
Member

@adeveloper-wq adeveloper-wq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general everything works great. Tested it on my iPhone and the old Moto-Android. Just found one typo and the layout glitch in the routing view.

@PaulPickhardt PaulPickhardt merged commit 8fe042f into dev Jun 12, 2024
1 check passed
@PaulPickhardt PaulPickhardt deleted the package-update branch June 12, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Packages (also major versions)
2 participants