-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Flutter to 3.19.6 and package upgrades (especially Mapbox 2.0.0) #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeveloper-wq
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general everything works great. Tested it on my iPhone and the old Moto-Android. Just found one typo and the layout glitch in the routing view.
adeveloper-wq
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If available, link to the ticket
Closes: #542
I could only upgrade to Flutter 3.19.6 due to a bug regarding UniqueKey. The
toString()
method behaves differently in release mode. We habe to wait for the hotfix.With Flutter 3.22.0 the
colorScheme
attributesbackground
,onBackground
andsurfaceVariant
get deprecated. I already refactored this when testing the 3.22.1 version. I think we should apply this change already.Our color mapping was not consistent anyway.
Primary
andsurface
were the same. The migration forbackground
suggests moving it tosurface
.That is the color mapping I applied:
surface
= value ofbackground
onSurface
= value ofonBackground
The use in the code needed to change:
surface
=>primary
onSurface
=>onPrimary
background
=>surface
onBackground
=>onSurface
When we upgrade to flutter 3.22.x, the only thing we need to change is: renaming
surfaceVariant
tosurfaceContainer
.QA Checklist
Author
Reviewer