Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sg not centered correctly after device orientation changed #588

Closed
wants to merge 3 commits into from

Conversation

PaulPickhardt
Copy link
Member

@PaulPickhardt PaulPickhardt commented Jun 10, 2024

If available, link to the ticket

Closes: #554

It can be tested by starting a ride, selecting a sg, and switching device orientation.

QA Checklist

Author

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Reviewer

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Sorry, something went wrong.

@adeveloper-wq
Copy link
Member

Discussed with Paul and we came to the conclusion that this edge case is not worth the extra logic and increased complexity in the code. Therefore we discard this fix for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation switch after user selects sg leads to bad display of the route
2 participants