Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app icon also for older android versions #602

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

PaulPickhardt
Copy link
Member

@PaulPickhardt PaulPickhardt commented Jun 17, 2024

If available, link to the ticket

Closes: #601

Tested on Android 7, 11, 14 on multiple devices. It works good and also fixes the bug which crashes the app if the app icon is null (Android 7 devices)

QA Checklist

Author

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Reviewer

  • Code Review
  • Functionality Tested (iOS and Android + different screens)
  • Light/Dark Mode Tested
  • Performance/Energy Consumption Tested (especially in ride view)

Copy link
Member

@adeveloper-wq adeveloper-wq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paul is going to test this on two other emulators and afterwards this can be merged.

@PaulPickhardt PaulPickhardt merged commit 790c2e0 into dev Jun 19, 2024
1 check passed
@PaulPickhardt PaulPickhardt deleted the fix/app-icons branch June 19, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Icon apparently not available on all devices
2 participants