Add fallback backends with respect to load + Backend rework #613

adeveloper-wq · 2024-06-21T11:29:31Z

If available, link to the ticket

Closes: #562 #561

QA Checklist

Author

Code Review
Functionality Tested (iOS and Android + different screens)
Light/Dark Mode Tested
Performance/Energy Consumption Tested (especially in ride view)

Reviewer

Code Review
Functionality Tested (iOS and Android + different screens)
Light/Dark Mode Tested
Performance/Energy Consumption Tested (especially in ride view)

…d and use default if both are not usable

PaulPickhardt

Looking really good! Tested on both iOS and android for different types of responses. Just added some minor refactoring.

After we discussed the 2 comments, we can merge this PR.

lib/settings/services/auth.dart

lib/settings/models/backend.dart

PaulPickhardt · 2024-06-24T11:33:58Z

Please also double-check my last commit @adeveloper-wq

…-app into backend-rework

PaulPickhardt and others added 25 commits June 5, 2024 10:25

Start rework load service

8977497

Fix wordinf

2cf05bf

Remove sendStartNotification

a3e70d9

Add first failover implementation

d04ad23

Add failover implementation when loading the app

8596c3a

Remove option to use beta deployment for normal users

0117560

Merge dev

f694d90

Start reworking load service

7eecd9d

Rework failover implementation

0ac43b0

Fix comment

26bda3a

Refactor code

322c4e0

Refactor code

77c9ce5

Add recommendFallback to model

8fc634c

Fix typo

f546d2b

WIP

3840f22

Fix syntax

1cf736d

Refactor load servi e

9241e38

Fix title in home view

74165e8

Fix persistence of city selection

7428635

Remove second get backend function in settings and refactor code

3961460

Rename node to backend

ee222b1

fix prev value set city

9de53cd

Remove unused load service

e5396b6

Remove unused isLoading and reset in load service

a1daee5

Refactor checkLoad function to check both default and fallback backen…

fb39397

…d and use default if both are not usable

PaulPickhardt approved these changes Jun 24, 2024

View reviewed changes

lib/settings/services/auth.dart Outdated Show resolved Hide resolved

lib/settings/models/backend.dart Show resolved Hide resolved

PaulPickhardt and others added 3 commits June 24, 2024 13:52

Add naming convention for backends

c1a0aeb

Fix auth service to support multiple configs

3f1b9e0

Refactor load service

c16713d

adeveloper-wq and others added 3 commits June 25, 2024 12:44

Undo backend renaming

2cb2ea9

Fix fallback logic

7983b5a

Merge branch 'backend-rework' of github.com:priobike/priobike-flutter…

fae2009

…-app into backend-rework

adeveloper-wq changed the base branch from feature/load-status-rework to dev June 25, 2024 10:49

adeveloper-wq changed the title ~~Backend rework~~ Add fallback backends with respect to load + Backend rework Jun 25, 2024

Merge dev into backend-rework

f798644

adeveloper-wq merged commit ac48e2d into dev Jun 25, 2024
1 check passed

adeveloper-wq deleted the backend-rework branch June 25, 2024 12:07

adeveloper-wq mentioned this pull request Jun 25, 2024

Rework load status and add failover implementation #585

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fallback backends with respect to load + Backend rework #613

Add fallback backends with respect to load + Backend rework #613

adeveloper-wq commented Jun 21, 2024 •

edited

Loading

PaulPickhardt left a comment

PaulPickhardt commented Jun 24, 2024

Add fallback backends with respect to load + Backend rework #613

Add fallback backends with respect to load + Backend rework #613

Conversation

adeveloper-wq commented Jun 21, 2024 • edited Loading

If available, link to the ticket

QA Checklist

Author

Reviewer

PaulPickhardt left a comment

Choose a reason for hiding this comment

PaulPickhardt commented Jun 24, 2024

adeveloper-wq commented Jun 21, 2024 •

edited

Loading