Add new cargo bike GraphHopper profile #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The updated GraphHopper is deployed now. Thus, this can be reviewed now. @PaulPickhardt (OSM and DRN should work). |
|
@adeveloper-wq tested in production. Only DRN worked. OSM did not have the cargo default profile. Maybe the service is not updated yet in production. I will have a look. Should it also work in release currently or do we update release later? |
Could be. It should also work in release. |
|
Release and production OSM is now updated. Works fine! |
PaulPickhardt
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If available, link to the ticket
Closes: #629
❗ Wait with merging until the GraphHopper is properly upgraded. As of now it does not have this profile.
QA Checklist
Author
Reviewer