Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected sg jumps to early by correcting the distances on route #666

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix selected sg jumps to early by correcting the distances on route #666

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e48ccef
Fix selected sg jumps to early by correcting the distances on route
PaulPickhardt Aug 20, 2024
5e66db8
Refactor code
PaulPickhardt Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/routing/models/route.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,19 @@ class Route {
final last = route.isNotEmpty ? route.last : null;
final distToLast =
last == null ? null : vincenty.distance(LatLng(last.lat, last.lon), LatLng(endpoint.lat, endpoint.lon));

// The distance to the first waypoints needs to be added to the signal group distances to calculate correct distances on route.
if (distToFirst != null) {
for (var i = 0; i < signalGroupsDistancesOnRoute.length; i++) {
signalGroupsDistancesOnRoute[i] += distToFirst;
}

// Also add the start distance for crossing distances on route.
for (var i = 0; i < crossingsDistancesOnRoute.length; i++) {
crossingsDistancesOnRoute[i] += distToFirst;
}
}

return Route(
idx: idx,
path: path,
Expand Down
Loading