Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add development workflow for Accelerate #5505

Merged
merged 29 commits into from
Dec 5, 2023
Merged

feat: add development workflow for Accelerate #5505

merged 29 commits into from
Dec 5, 2023

Conversation

ankur-arch
Copy link
Contributor

This section describes how it would look like to use Accelerate in development

@ankur-arch ankur-arch self-assigned this Nov 27, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 0:03am

@github-actions GitHub Actions
Copy link
Contributor

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions GitHub Actions
Copy link
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

@github-actions GitHub Actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 20%, saving 54.94 KB.

Filename Before After Improvement Visual comparison
content/800-data-platform/100-accelerate/images/accelerate-in-dev.png 133.15 KB 107.18 KB -19.5% View diff
content/800-data-platform/100-accelerate/images/accelerate-in-prod.png 141.51 KB 112.53 KB -20.5% View diff

196 images did not require optimisation.

nikolasburk
nikolasburk approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be a very useful resource 🙌

@ankur-arch ankur-arch merged commit bc23307 into main Dec 5, 2023
6 of 7 checks passed
@ankur-arch ankur-arch deleted the accelerate-in-dev branch December 5, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@ruheni ruheni ruheni approved these changes

@nikolasburk nikolasburk nikolasburk approved these changes

@rtbenfield rtbenfield Awaiting requested review from rtbenfield

@jharrell jharrell Awaiting requested review from jharrell

Assignees

@ankur-arch ankur-arch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankur-arch @janpio @nikolasburk @ruheni