test: unskip previously skipped tests

prismicio · Oct 27, 2023 · 3ccfbf6 · 3ccfbf6
1 parent e7533b4
commit 3ccfbf6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/cypress/e2e/slices/00-create.cy.js b/cypress/e2e/slices/00-create.cy.js
@@ -16,7 +16,7 @@ describe("Create Slices", () => {
     cy.clearProject();
   });
 
-  it.skip("A user can create and rename a slice", () => {
+  it("A user can create and rename a slice", () => {
     cy.createSlice(lib, sliceId, sliceName);
 
     sliceBuilder.addNewWidgetField("Title", "Key Text");
@@ -144,7 +144,7 @@ describe("Create Slices", () => {
   });
 
   // See: #791
-  it.skip("A user cannot rename a slice with a name starting with a number", () => {
+  it("A user cannot rename a slice with a name starting with a number", () => {
     const sliceName = "SliceName";
 
     cy.createSlice(lib, sliceId, sliceName);

diff --git a/cypress/e2e/user-flows/scenario_custom_screenshots.cy.js b/cypress/e2e/user-flows/scenario_custom_screenshots.cy.js
@@ -26,7 +26,7 @@ describe("I am an existing SM user and I want to upload screenshots on variation
     sliceBuilder.goTo(slice.library, slice.name);
   });
 
-  it.skip("Upload and replace custom screenshots", () => {
+  it("Upload and replace custom screenshots", () => {
     // Upload custom screenshot on default variation
     sliceBuilder.imagePreview.should("not.exist");
     sliceBuilder.openScreenshotModal();

diff --git a/packages/slice-machine/src/features/slices/sliceCards/SharedSliceCard.tsx b/packages/slice-machine/src/features/slices/sliceCards/SharedSliceCard.tsx
@@ -116,6 +116,7 @@ export const SharedSliceCard: FC<SharedSliceCardProps> = (props) => {
     >
       {src !== undefined ? (
         <CardMedia
+          alt="Preview image"
           overlay={
             canUpdateScreenshot && !disableOverlay ? (
               <Box alignItems="center" justifyContent="center">
@@ -156,9 +157,12 @@ export const SharedSliceCard: FC<SharedSliceCardProps> = (props) => {
           ) : action.type === "menu" ? (
             <DropdownMenu modal>
               <DropdownMenuTrigger disabled={disabled}>
-                <IconButton icon="moreVert" />
+                <IconButton data-cy="slice-action-icon" icon="moreVert" />
               </DropdownMenuTrigger>
-              <DropdownMenuContent align="end">
+              <DropdownMenuContent
+                align="end"
+                data-cy="slice-action-icon-dropdown"
+              >
                 {action.onRename ? (
                   <DropdownMenuItem
                     onSelect={action.onRename}

diff --git a/packages/slice-machine/test/pages/slices.test.tsx b/packages/slice-machine/test/pages/slices.test.tsx
@@ -31,7 +31,7 @@ describe("slices", () => {
     mockRouter.setCurrentUrl("/slices");
   });
 
-  test.skip("When user creates a slice it should send a tracking event", async (ctx) => {
+  test("When user creates a slice it should send a tracking event", async (ctx) => {
     const adapter = createTestPlugin({
       setup: ({ hook }) => {
         hook("slice:create", () => void 0);
@@ -206,7 +206,7 @@ describe("slices", () => {
     );
   });
 
-  test.skip("if creation fails it sohuld not send the tracking event", async (ctx) => {
+  test("if creation fails it sohuld not send the tracking event", async (ctx) => {
     const adapter = createTestPlugin({
       setup: ({ hook }) => {
         hook("slice:create", () => {