Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SlicesTemplates): Add from template button #1123

Closed
wants to merge 1 commit into from

Conversation

xrutayisire
Copy link
Collaborator

@xrutayisire xrutayisire commented Aug 30, 2023

Context

The Solution

  • Display a dropdown menu item in the slice zone header, as it will be in the future design
  • Add a simple button in the slice zone blank slate

Impact / Dependencies

  • Need function to detect if slices templates is supported merged

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

Preview

Screenshot 2023-08-30 at 20 06 29
Screenshot 2023-08-30 at 20 06 39

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Aug 31, 2023 2:56pm

@linear
Copy link

linear bot commented Aug 30, 2023

DT-1582 AAUser I have a button add slice templates from Slice Zone

The goal is from the Slice Zone header and Slice Zone blank slate be able to click on a button that open the modal to select Slice Templates.

The button would be like the current design without any more information.

The goal is to only display the button if slice templates feature is supported.

It would mean 3 buttons in the header and the blank slate until future iterations.

@xrutayisire xrutayisire force-pushed the xru/add-from-template-button branch from a33d86f to 2762587 Compare August 31, 2023 14:48
@xrutayisire xrutayisire changed the base branch from xru/function-to-detect-support-slices-templates to dev-next-release August 31, 2023 14:48
@xrutayisire xrutayisire closed this Sep 4, 2023
@xrutayisire xrutayisire deleted the xru/add-from-template-button branch December 20, 2023 10:42
@xrutayisire xrutayisire restored the xru/add-from-template-button branch December 20, 2023 10:42
@xrutayisire xrutayisire deleted the xru/add-from-template-button branch December 20, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant