Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page type): Fix problem when closing modals after creating a page type #1171

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(page type): Fix problem when closing modals after creating a page type #1171

merged 1 commit into from
Oct 16, 2023

Conversation

xrutayisire
Copy link
Collaborator

Context

  • Fix a bug when you close a modal that allow you to add slice from the Page Type blank slate

The Solution

  • Only redirect after a success

Impact / Dependencies

  • None

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 16, 2023 2:52pm

@xrutayisire xrutayisire merged commit 2b05aca into dev-next-release Oct 16, 2023
23 checks passed
@xrutayisire xrutayisire deleted the xru/fix-bug-creation-page-type branch October 16, 2023 16:15
@xrutayisire
Copy link
Collaborator Author

DT-1686

@xrutayisire xrutayisire mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bapmrl bapmrl bapmrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrutayisire @bapmrl