Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page type): Convert to page type should create slice zone for main tab if necessary #1172

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(page type): Convert to page type should create slice zone for main tab if necessary #1172

merged 1 commit into from
Oct 17, 2023

Conversation

xrutayisire
Copy link
Collaborator

Context

The Solution

  • Create shared functions that should allow us to easily manipulate custom type without CustomTypeSM
  • Ensure slice zone is created for main tab if necessary when converting a custom type to page type

Impact / Dependencies

  • New cool functions to use now 🙂

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

Preview

Screen.Recording.2023-10-16.at.18.12.41.mov

@linear
Copy link

linear bot commented Oct 16, 2023

DT-1687 Convert to page type don't create slice zone when necessary

When you convert a custom type to a page type and there is no slice zone for the main tab, it should be created by default, so the user can actually add slices after.

Slack thread: https://prismic-team.slack.com/archives/CPG31MDL1/p1697447854246149

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 17, 2023 2:17pm

@xrutayisire xrutayisire force-pushed the xru/create-slice-zone-when-converting-to-page-type branch 2 times, most recently from 708f67e to 9a3cc7a Compare October 17, 2023 13:44
@xrutayisire xrutayisire force-pushed the xru/create-slice-zone-when-converting-to-page-type branch from 9a3cc7a to d5877cc Compare October 17, 2023 14:12
@xrutayisire xrutayisire merged commit 15ccb00 into dev-next-release Oct 17, 2023
@xrutayisire xrutayisire deleted the xru/create-slice-zone-when-converting-to-page-type branch October 17, 2023 14:24
@xrutayisire xrutayisire mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihbr lihbr lihbr left review comments

@hypervillain hypervillain hypervillain left review comments

@bapmrl bapmrl bapmrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xrutayisire @hypervillain @bapmrl @lihbr