-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support environments in @slicemachine/plugin-kit
, @slicemachine/manager
, and adapters (DT-1650, DT-1721)
#1182
Conversation
…ment:update` hooks
…roject.updateEnvironment()`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a pre-review, but it looks good to me so far :)
For Nuxt it'll be able to work similarly, the environment variable will be: NUXT_PUBLIC_PRISMIC_ENDPOINT
Happy to do it, but if you want to give it a shot, sure thing!
As you said, it'll be nice to abstract the env-reading utils to plugin-kit/fs
…Environment()` helpers
…onment:update` hooks
…ronment:update` hooks
@slicemachine/plugin-kit
, @slicemachine/manager
, and adapters@slicemachine/plugin-kit
, @slicemachine/manager
, and adapters (DT-1650, DT-1721)
DT-1721 AADev, I want to use correct types for environments list
After review with platform, we ended up with this structure for environments:
Code that relies on them should be updated accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, really nice work!
Will be merged into a separate PR. |
Important
This PR is based on #1160.
Context
DT-1650, DT-1721
The Solution
project:environment:read
project:environment:update
manager.project.readEnvironment()
manager.project.updateEnvironment()
@slicemachine/plugin-kit/fs
helpers:readProjectEnvironment()
writeProjectEnvironment()
@slicemachine/adapter-next
@slicemachine/adapter-nuxt
@slicemachine/adapter-nuxt2
@slicemachine/adapter-sveltekit
Impact / Dependencies
This work will coincide with work on the Slice Machine API.
Checklist before requesting a review