Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start-slicemachine): Remove logged in info when starting Slice Machine #1185

Merged

Conversation

xrutayisire
Copy link
Collaborator

Context

The Solution

  • Remove all related code to the logged in info

Impact / Dependencies

  • None

Checklist before requesting a review

  • I hereby declare my code ready for review.
  • If it is a critical feature, I have added tests.
  • The CI is successful.
  • If there could backward compatibility issues, it has been discussed and planned.

@linear
Copy link

linear bot commented Oct 23, 2023

DT-1697 [init] Not logged in and I don't know why

When you say yes to start slice machine directly after the init, it says Not logged in, this information is not useful and can confuse users. We can remove it from start-slicemachine for all use cases.

Screenshot 2023-10-18 at 14.25.55.png

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 23, 2023 11:36am

@xrutayisire xrutayisire changed the title feat(start-slicemachine): Remove logged in info when starting Slice Machine [1.19.0] feat(start-slicemachine): Remove logged in info when starting Slice Machine Oct 23, 2023
Copy link
Member

@lihbr lihbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xrutayisire xrutayisire merged commit 570d60e into dev-next-release Oct 23, 2023
23 checks passed
@xrutayisire xrutayisire deleted the xru/remove-logged-in-info-start-slicemachine branch October 23, 2023 16:35
@bapmrl bapmrl changed the title [1.19.0] feat(start-slicemachine): Remove logged in info when starting Slice Machine feat(start-slicemachine): Remove logged in info when starting Slice Machine Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants