Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cypress-setup.sh #1197

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

bapmrl
Copy link
Collaborator

@bapmrl bapmrl commented Oct 27, 2023

Our E2E tests can no longer run because:

  1. Next.js 14 has just been released.
  2. Our cypress-setup.sh script uses a version of create-next-app (version 13.4.6) that always installs the latest version of Next.js.
  3. Our @slicemachine/adapter-next package isn't compatible with Next.js 14.

Changing the version of create-next-app to 13.5.4 solves the issue, as it no longer installs the latest version of Next.js, but the version listed in its package.json file.

@bapmrl bapmrl self-assigned this Oct 27, 2023
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Oct 27, 2023 9:32am

Copy link
Collaborator

@xrutayisire xrutayisire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@bapmrl bapmrl merged commit cdb396d into dev-next-release Oct 27, 2023
@bapmrl bapmrl deleted the bmo/chore-fix-cypress-setup branch October 27, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants