Test sm update command #1252
Merged
Test sm update command #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xrutayisire
changed the base branch from
main
to
xru/convert-cypress-tests-3
xrutayisire
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
LGTM!
We could reuse part of the same string for the update command that are in common or even for the tests. But as I shared with you and Angelo already, duplication in tests can even be better to reduce overhead, and it's super easy to improve it if necessary in the future depending on our needs.
Super nice to see your first Playwright tests 🎉
xrutayisire
force-pushed
the
xru/convert-cypress-tests-3
branch
3 times, most recently
from
ca8a52d to
d3b0dde
Compare
xrutayisire
force-pushed
the
test-sm-update-command
branch
from
4519c99 to
b0f5adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Playwright tests for npm and yarn update sm to latest