fix: ESM error when using SST #1279
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -16,6 +16,8 @@ export const format = async ( | |||
| filePath: string, | |||
| options?: FormatOptions, | |||
| ): Promise<string> => { | |||
| const prettier = await import("prettier"); | |||
There was a problem hiding this comment.
❓ Can dynamically loading the prettier module impact the performance of the format function? I'm thinking of what could happen with a large amount of consecutive calls.
There was a problem hiding this comment.
Dynamic imports shouldn't significantly impact performance unless the module contains a lot of code. Prettier is large, so it's possible it could cause slow-downs, but I don't think it would be significant enough to worry about it.
Typically only the first load takes longer. I think Node.js's import cache speeds up subsequent imports.
|
It turns out this change didn't work. Instead, we need to include |
Context
This PR fixes an issue when
@slicemachine/manageris used in an SST application.The Solution
Move
prettierinto a dynamic import. Prettier declares__dirnamein its code, which conflicts with SST's__dirnamedefinition.Impact / Dependencies
N/A
Checklist before requesting a review