feat(auto-sync): Add an AutoSyncProvider and trigger a sync changes when needed #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xrutayisire
changed the title
xrutayisire
force-pushed
the
xru/auto-sync-provider
branch
from
eaa78ac to
627ef87
Compare
xrutayisire
force-pushed
the
xru/auto-sync-provider
branch
from
627ef87 to
70d9a10
Compare
hypervillain
suggested changes
Feb 7, 2024
| collisionPadding={280} | ||
| trigger={ | ||
| <Box padding={{ bottom: 24 }}> | ||
| {autoSyncStatus === "failed" || |
There was a problem hiding this comment.
Possible alternate syntax: ["failed", "sync", "syncing"].includes(autoSyncStatus)
There was a problem hiding this comment.
The problem is Typescript then, I did the same comment to one PR from Baptiste and TypeScript don't understand this syntax :/
| loggedIn = isOnline && authStatus === AuthStatus.AUTHORIZED, | ||
| } = args; | ||
|
|
||
| console.log("1. Just calling syncChanges"); |
There was a problem hiding this comment.
Removed, console.log for QA on the alpha
packages/slice-machine/src/features/sync/components/AutoSyncStatusIndicator.tsx
Outdated
Show resolved
Hide resolved
xrutayisire
force-pushed
the
xru/auto-sync-provider
branch
from
70d9a10 to
156c971
Compare
xrutayisire
force-pushed
the
xru/remove-rename-slice-saga
branch
from
cc80883 to
343c771
Compare
xrutayisire
force-pushed
the
xru/auto-sync-provider
branch
2 times, most recently
from
0877fcb to
42e3c71
Compare
hypervillain
approved these changes
Feb 8, 2024
xrutayisire
force-pushed
the
xru/auto-sync-provider
branch
from
42e3c71 to
16300ac
Compare
xrutayisire
force-pushed
the
xru/auto-sync-provider
branch
from
16300ac to
04100b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Solution
unSyncChangesare created (not perfect but the goal was to improve it still)Changesitem linkgetLegacySliceMachineStatebecause it's the same code as "getState", easier for the future removal of getStateImpact / Dependencies