Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update api endpoints #1379

Merged
merged 4 commits into from
Jan 14, 2025
Merged

chore: update api endpoints #1379

merged 4 commits into from
Jan 14, 2025

Conversation

xrutayisire
Copy link
Collaborator

@xrutayisire xrutayisire commented Jun 3, 2024 •
edited
Loading

Description

  • Use new /push endpoint from sm-api to bulk update changes
  • Rename the stage URL for sm-api
  • Rename the stage URL for AwsAclProvider
  • Rename the prod URL for AwsAclProvider

Checklist

  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@vercel Vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Jan 13, 2025 10:44pm

angeloashmore
angeloashmore approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@angeloashmore angeloashmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a quick question about a type that may be able to simplify.

packages/manager/src/managers/prismicRepository/types.ts Outdated Show resolved Hide resolved
@xrutayisire xrutayisire requested a review from a team as a code owner June 7, 2024 09:59
@xrutayisire xrutayisire requested a review from a team as a code owner July 15, 2024 13:16
@xrutayisire xrutayisire marked this pull request as draft August 23, 2024 08:52
@xrutayisire xrutayisire force-pushed the xru/use-push-from-sm-api branch from 7d1946a to 139900d Compare January 13, 2025 21:19
@xrutayisire xrutayisire changed the title chore(push): Use new push endpoint from sm-api chore: update api endpoints Jan 13, 2025
@xrutayisire xrutayisire marked this pull request as ready for review January 13, 2025 22:38
@xrutayisire xrutayisire merged commit ab744f5 into main Jan 14, 2025
34 of 35 checks passed
@xrutayisire xrutayisire deleted the xru/use-push-from-sm-api branch January 14, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloashmore angeloashmore angeloashmore approved these changes

@dani-mp dani-mp dani-mp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrutayisire @dani-mp @angeloashmore