Add link variant box #1502
Add link variant box #1502
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/slice-machine/src/legacy/lib/models/common/widgets/Link/components.tsx
Show resolved
Hide resolved
| Variants | ||
| </Text> | ||
| <Text color="grey11"> | ||
| Add variants like "Primary" and "Secondary" to allow editors to choose |
There was a problem hiding this comment.
💡 I also prefer your new copy, I let you confirm it with Côme for both sentences and all good for me.
| Variants | ||
| </Text> | ||
| <Text color="grey11"> | ||
| Add variants like "Primary" and "Secondary" to allow editors to choose |
There was a problem hiding this comment.
Note: At the same time, I couldn't find the correct grey value from Figma, seems weird and not coming from the DS. Maybe we could just took the darker version of this as visible in the design.
There was a problem hiding this comment.
yeah, the color doesn't exist in the new design system, so i picked the closest one that looked right
Maybe we could just took the darker version of this as visible in the design
not sure i understood this message, could you clarify?
There was a problem hiding this comment.
From the design, I feel the color should be darker. Maybe we could use one a darker to be closer to the design?
Since this one is the same as the others texts it's too close and don't match design.
There was a problem hiding this comment.
i see what you mean now, i've used the darker color now, let mem know what you think!
Resolves:
Part of https://linear.app/prismic/issue/DT-2474/aadev-i-can-create-a-link-field-with-the-new-option-to-enable-and.
Description
Adds the box introducing the new feature, without any functionality.
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩