Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link variant #1505

Merged
merged 49 commits into from
Jan 10, 2025
Merged

Link variant #1505

merged 49 commits into from
Jan 10, 2025

Conversation

dani-mp
Copy link
Contributor

@dani-mp dani-mp commented Dec 13, 2024 •
edited
Loading

Resolves:
https://linear.app/prismic/project/links-variants-87bf1b25043c/overview#milestone-35e9e2c6-ecbe-4b11-be33-e0e71bc62bc8

Description

Base branch for all the work related to link variant. All the code here has been reviewed previously by the team.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
slice-machine ✅ Ready (Inspect) Visit Preview Jan 10, 2025 2:54pm

@dani-mp dani-mp marked this pull request as ready for review January 9, 2025 13:35
@dani-mp dani-mp requested a review from a team as a code owner January 9, 2025 13:35
@dani-mp dani-mp force-pushed the dani/link-variant branch from 652823e to 9ba0464 Compare January 9, 2025 14:07
@dani-mp dani-mp mentioned this pull request Jan 10, 2025
Merged
4 tasks
xrutayisire
xrutayisire approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@xrutayisire xrutayisire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's gooo!!

@dani-mp dani-mp merged commit bc2d382 into main Jan 10, 2025
33 checks passed
@dani-mp dani-mp deleted the dani/link-variant branch January 10, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrutayisire xrutayisire xrutayisire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani-mp @xrutayisire