Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix 404 status URL #1933

Conversation

braveocheretovych
Copy link
Contributor

@braveocheretovych braveocheretovych commented Nov 12, 2024

fixing broken links

Description
Add missing exports for contracts package

Additional Notes
N/A

Related issue(s)
Related to privacy-scaling-explorations/maci-platform#433

Confirmation
I have read and understand MACI's contributor guidelines and code of conduct.
I have read and understand MACI's #847.
I have read and understand MACI's testing guide.

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Dec 3, 2024 6:55am

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please ensure that the commit message respects these guidelines https://maci.pse.dev/docs/contributing/#commits-rules

@braveocheretovych braveocheretovych changed the title docs: replacement of idle links docs: fixing broken links Nov 22, 2024
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Dec 2, 2024

@braveocheretovych checking if you saw my comment regarding the CI failure, your commit message would need to be amended before this is merged. more info: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

@braveocheretovych braveocheretovych changed the title docs: fixing broken links chore: fix 404 status URL Dec 3, 2024
@ctrlc03
Copy link
Collaborator

ctrlc03 commented Dec 4, 2024

@braveocheretovych i saw you changed the title of the PR, however you will need to change the actual commit message. I sent a link on how that works and also there's more info here: https://maci.pse.dev/docs/contributing/#pull-requests

@braveocheretovych
Copy link
Contributor Author

I'm just new to this topic. I made a commit through editing on Github without a terminal, I can't figure out how to fix this problem

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Dec 5, 2024

@braveocheretovych you could close this PR and open a new one, but make sure your commit message is "chore: fix 404 status URL"

@braveocheretovych
Copy link
Contributor Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants