-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: voice credit per tokens (ERC20 or ETH sent to an address) #1998
Draft
NicoSerranoP
wants to merge
17
commits into
dev
Choose a base branch
from
feat/voice-credit-per-tokens
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,878
−871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] Add relayer package - [x] Add boilerplate package for relayer
Co-authored-by: Crisgarner <@crisgarner>
Signed-off-by: linchizhen <[email protected]>
Co-authored-by: Crisgarner <@crisgarner>
- [x] Add controller api method for message publishing - [x] Add tests - [x] Add dto and validation
- [x] Add mongodb integration - [x] Add message repository - [x] Add message batch repository - [x] Add message batch service - [x] Add message and message batch schemas - [x] Integrate message repository into message service - [x] Integrate message batch service into message service
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
please rebase to dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need a feature to give each voter a specific voice credit amount depending on how much ERC-20 tokens or ETH the user has send to an address. Related to #1968
Steps:
PerTokenVoiceCreditProxy
contractregisterVoiceCredits
(this is happening outside any Poll or MACI function. Should it stay that way or should we integrate it into thejoinPoll
step?)getVoiceCredits
to calculate how much credit a voter hasRelated issue(s)
Close #1968
Confirmation
Important
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.