feat: ferret #202
Open
feat: ferret #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
th4s
approved these changes
Jan 27, 2025
| /// # Arguments | ||
| /// | ||
| /// * `depth` - The depth of the tree. | ||
| /// * `seed` - The seed of the tree. |
There was a problem hiding this comment.
Suggested change
| /// * `seed` - The seed of the tree. | |
| /// * `seed` - The seed of the tree. | |
| /// * `leaves` - The last layer of blocks. |
Comment on lines
+138
to
+139
| /// Returns the layer at the given height. | ||
| pub fn layer(&self, height: usize) -> Option<&[Block]> { |
| /// | ||
| /// * `depth` - Depth of the tree. | ||
| /// * `sums` - Sum of the left or right nodes for each layer. | ||
| /// * `idx` - Index of the missing leaf. |
Comment on lines
+157
to
+158
| let mut left = Block::ZERO; | ||
| let mut right = Block::ZERO; |
There was a problem hiding this comment.
Why do we have to set both to zero here?
Comment on lines
+144
to
+187
| static UNIFORM_PARAMS: &[LpnParameters] = &[ | ||
| LpnParameters { | ||
| n: 545_656, | ||
| k: 34_643, | ||
| t: 1_050, | ||
| }, | ||
| LpnParameters { | ||
| n: 1_071_888, | ||
| k: 40_800, | ||
| t: 1720, | ||
| }, | ||
| LpnParameters { | ||
| n: 5_324_800, | ||
| k: 240_000, | ||
| t: 1_300, | ||
| }, | ||
| LpnParameters { | ||
| n: 10_488_928, | ||
| k: 458_000, | ||
| t: 1280, | ||
| }, | ||
| ]; | ||
|
|
||
| static REGULAR_PARAMS: &[LpnParameters] = &[ | ||
| LpnParameters { | ||
| n: 518_656, | ||
| k: 34_643, | ||
| t: 1_013, | ||
| }, | ||
| LpnParameters { | ||
| n: 1_740_800, | ||
| k: 66_400, | ||
| t: 1700, | ||
| }, | ||
| LpnParameters { | ||
| n: 5_324_800, | ||
| k: 240_000, | ||
| t: 1_300, | ||
| }, | ||
| LpnParameters { | ||
| n: 10_485_760, | ||
| k: 458_000, | ||
| t: 1280, | ||
| }, |
There was a problem hiding this comment.
Are these numbers from the Ferret paper? I cannot find them.
| for (item, bucket_length) in cuckoo.iter().zip(buckets.iter_buckets()) { | ||
| // pad to power of 2. | ||
| let power_of_two = (bucket_length + 1) | ||
| .checked_next_power_of_two() |
There was a problem hiding this comment.
I cannot find this rounding up to the next power of 2 in the paper. On the other hand the SPCOT protocol only works with powers of 2. Is this somehow implied or how did you come up with it?
|
|
||
| idxs.push(pos); | ||
| } else { | ||
| idxs.push(bucket_length); |
There was a problem hiding this comment.
Shouldn't this be bucket_length + 1?
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `derandomize` - SPCOT derandomization bits from the receiver. |
There was a problem hiding this comment.
Suggested change
| /// * `derandomize` - SPCOT derandomization bits from the receiver. | |
| /// * `msg` - SPCOT derandomization bits from the receiver. |
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `derandomize` - SPCOT derandomization bits from the receiver. |
|
|
||
| let spcot_count: usize = spcot_lengths.iter().sum(); | ||
| let masks = &self.choices[self.choices.len() - spcot_count..]; | ||
| let derandomize = self.spcot.derandomize(&spcot_lengths, &spcot_idxs, masks)?; |
There was a problem hiding this comment.
What about truncating self.choices here, instead of line 193?
th4s
reviewed
Jan 29, 2025
Comment on lines
+129
to
+132
| m * ((2 * HASH_NUM as usize * params.n / m) | ||
| .checked_next_power_of_two() | ||
| .expect("The length should be less than usize::MAX / 2 - 1") | ||
| .ilog2() as usize) |
There was a problem hiding this comment.
Can you explain how you arrive at this specific part?
th4s
reviewed
Jan 29, 2025
| // *Assumes the parameters are in ascending order.* | ||
| for param in params { | ||
| let cost = iteration_cost(ty, *param); | ||
| let net = param.t - cost; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing Ferret implementation to fit into the recent interface changes. I've also done some cleaning up here and there, including removing a quadratic cost algorithm present in the uniform MPCOT implementation.
Builds on #171