Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RandomOT traits and implement them for KOS15 #91

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Add RandomOT traits and implement them for KOS15 #91

merged 6 commits into from
Jan 17, 2024

Conversation

th4s
Copy link
Member

@th4s th4s commented Jan 15, 2024

This PR adds the traits RandomOTSender and ChosenMessageRandomOTReceiver and implements them for KOS15.

@th4s th4s requested review from themighty1 and sinui0 January 15, 2024 15:00
sinui0
sinui0 requested changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, seems pretty straight forward.

Can we get a test in there too?

ot/mpz-ot/src/kos/mod.rs Outdated Show resolved Hide resolved
ot/mpz-ot/src/lib.rs Outdated Show resolved Hide resolved
ot/mpz-ot/src/lib.rs Outdated Show resolved Hide resolved
ot/mpz-ot/src/lib.rs Outdated Show resolved Hide resolved
ot/mpz-ot/src/lib.rs Outdated Show resolved Hide resolved
@th4s th4s requested a review from sinui0 January 16, 2024 14:20
sinui0
sinui0 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gw 👍

themighty1
themighty1 requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@themighty1 themighty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to discuss if the use of PRG can be avoided

ot/mpz-ot/src/kos/receiver.rs Show resolved Hide resolved
ot/mpz-ot/src/kos/sender.rs Show resolved Hide resolved
ot/mpz-ot/src/lib.rs Outdated Show resolved Hide resolved
ot/mpz-ot/src/lib.rs Outdated Show resolved Hide resolved
th4s and others added 2 commits January 17, 2024 14:07
@th4s @themighty1
Improve comments 1/2
bbb4436 
Adhere to new wording for OT

Co-authored-by: dan <[email protected]>
@th4s @themighty1
Improve comments 2/2
9c55c03 
Adhere to new wording for OT.

Co-authored-by: dan <[email protected]>
@th4s th4s merged commit 1b5573b into dev Jan 17, 2024
3 checks passed
@th4s th4s deleted the random-ot-traits branch January 17, 2024 13:48
sinui0 added a commit that referenced this pull request Jan 17, 2024
@sinui0
Squashed commit of the following:
34c8c90 
commit 1b5573b
Author: th4s <[email protected]>
Date:   Wed Jan 17 14:48:26 2024 +0100

    Add RandomOT traits and implement them for KOS15 (#91)

    * Add RandomOT traits and implement them for KOS15

    * Fix trait comments

    * Add part of feedback

    * Add test for KOS15 RandomOT

    * Improve comments 1/2

    Adhere to new wording for OT

    Co-authored-by: dan <[email protected]>

    * Improve comments 2/2

    Adhere to new wording for OT.

    Co-authored-by: dan <[email protected]>

    ---------

    Co-authored-by: dan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinui0 sinui0 sinui0 approved these changes

@themighty1 themighty1 themighty1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@th4s @themighty1 @sinui0