Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: init zk-kit.circom repository #1

Merged
merged 11 commits into from
May 10, 2024
Merged

chore: init zk-kit.circom repository #1

merged 11 commits into from
May 10, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented May 8, 2024

This PR initializes a new repo for hosting Circom circuits, copying the circuits from the ZK-Kit repository as part of a new structure of the ZK-Kit packages. ZK-Kit will have a repository per language.

Re privacy-scaling-explorations/zk-kit#282

@0xjei
Copy link
Member

0xjei commented May 9, 2024

the utils package circuit aren't building from compile root script. Got the following error:

[@zk-kit/utils.circom]: Process started
[@zk-kit/utils.circom]: ===| Compiling the circuit |===
[@zk-kit/utils.circom]: Error: No such circuit in ./circuits.json

@cedoor
Copy link
Member Author

cedoor commented May 9, 2024

the utils package circuit aren't building from compile root script. Got the following error:

I should have solved it! Let me know 👍🏽

@0xjei
Copy link
Member

0xjei commented May 9, 2024

the utils package circuit aren't building from compile root script. Got the following error:

I should have solved it! Let me know 👍🏽

yes, works fine - thank you for the quick fix

Copy link
Member

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, makes sense to have one package per circuit - the configs are lit, just a few nits!

packages/poseidon-proof/package.json Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@cedoor
Copy link
Member Author

cedoor commented May 9, 2024

amazing, makes sense to have one package per circuit - the configs are lit, just a few nits!

Thank you so much! Applied all changes you suggested 👍🏽

@cedoor cedoor merged commit 9a8cff6 into main May 10, 2024
1 check passed
@cedoor cedoor deleted the chore/init-repo branch May 10, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants