Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Implement IncrementalMerkleTree and DynamicCalculator
Description
This PR implements the
IncrementalMerkleTree
struct and theDynamicCalculator
trait for Field elements. The implementation includes several key functions:key_to_path
: Transforms a key into a big-endian array of bits.min
: A utility function to return the minimum of two u32 values.calculate_root_dynamic
: Calculates the root of the Merkle tree dynamically based on the provided leaf and siblings.calculate_two_roots
: Calculates two roots for a given leaf entry - one including the leaf and one excluding it.These implementations provide efficient methods for working with Merkle trees, particularly for proving membership of leaf entries while simultaneously modifying the tree.
Other information
This implementation is part of the zk-kit.noir project and enhances the functionality of Merkle trees within the system. It allows for more flexible and efficient operations on Merkle trees, which is crucial for many zero-knowledge proof applications.