feat: refactor, generics, bugfixes, and other nits #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @signorecello ! Looks like the style check is not passing |
|
Ok ended up with a big refactor to make the MTs generic. This is pretty cool (also shows the mighty power of Noir) because it allows all kinds of MTs, for example those with BigNums as leaves. Still encountering some weird errors, so WIP for now |
|
Damn it's 1am and I swear I'll never implement a merkle tree again (you know I'm lying). BUT I'm done with the refactor, needs a test tho (eating my own dogfood) |
signorecello
changed the title
madztheo
requested changes
Dec 11, 2024
madztheo
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make the MT implementation similar to the sparse merkle one, figured I got the whole
addanddeletelogic totally wrong... This fixes it.Totally refactored the lib to go along with it lol. It now accepts generics so you can use it with any type as long as they implement Default and Eq.
Added some tests with BigNums, as that will most likely be the biggest use-case outside of integers and Fields.